Fix incorrect conversion from TEXT to INTEGER when text is a number followed by a trailing non-breaking space #3878
+103
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitespace too. While SQLite only removes ASCII whitespace. Closes: tursodatabase#3679
krishvishal
requested review from
jussisaurio,
penberg and
pereman2
as code owners
Contributor
Author
|
Thinking about if I should replace |
|
Nyrkiö Report for Commit: 01d8456 No performance changes detected.
|
PThorpe92
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes incorrect conversion from TEXT to INTEGER when text is a number followed by a trailing non-breaking space.
This happens because
str::trim()trims non-breaking space and unicode whitespace while SQLite only trims ASCII whitespace.Closes: #3679